++, many thanks for the feedback!

I think, personally, when you look at the core data of the new one (the statConfig array), it's simpler than my first effort. Everything you need to know is in that array, and it just boils down to a few lines ... when you move the package into a separate file, the main routine is just the data structure, newing up the class, and calling a single method!

The complexity of introducing a data structure and whatnot is I guess offset by the benefits of generacity (is that a word?). And separation of functional code from data. And all that good stuff.

Moving forward, I think I might tack a Tk interface on the front, and perhaps add HTML::Parse in there to take care of errors. Keeping it generic, of course :)

Re: reading the data in from a file - if it got really complex I would make it XML. Since it's only a handful of GETs and POSTs, the effort of a nice config file is hard to justify.

Also: it's using https rather than http for everything. Wouldn't want people sniffing those SMS!

--
Ash OS durbatulk, ash OS gimbatul,
Ash OS thrakatulk, agh burzum-ishi krimpatul!
Uzg-Microsoft-ishi amal fauthut burguuli.

In reply to Re: Re: Perl2SMS (for Vodafone Australia) by hagus
in thread Perl2SMS (for Vodafone Australia) by hagus

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.