Thanks for your input. I've done some rewriting: 

#!/usr/bin/perl -w

#checks for valid email address
#usage validemail <file containing email addresses>

use warnings;
use strict;
use Email::Valid::Loose;
use Net::DNS;
use Parallel::ForkManager;

my $pm=new Parallel::ForkManager(20);
my $resolver=Net::DNS::Resolver->new();
my $addrfile = $ARGV[0];
my ($is_valid, $host, $ip, @goodaddr, @badaddr, $x, $record, @mx, $add
+, @adds);

#custom words that make emails invalid to you
my @custom = qw(
 postmaster
 webmaster
);
  

open (EMAILS, "$addrfile");

 while (<EMAILS>){
 $_ =~ s/\015//;
 chomp $_;
    push @adds, $_;
}
close (EMAILS);

open (BADADDR, ">badmails") || die;
open (GOODADDR, ">goodmails") || die;

OUTER: foreach $add (@adds){ 
    
    $pm->start and next;

    foreach $x (@custom){
            if ($add =~ m/$x/){
                print BADADDR "$add\n"; #address is bad
                $pm->finish;
            }
        }

        #if email is invalid move on
        if (!defined(Email::Valid::Loose->address($add))){
            print BADADDR "$add\n"; #address is bad
            $pm->finish;
        }

        #if email is valid get hostname
        $is_valid = Email::Valid::Loose->address($add);
        if ($is_valid =~ m/\@(.*)$/) {
            $host = $1;
        }
        $is_valid="";
        
        # perform dsn lookup to check domain
        @mx=mx($resolver, $host);

        if (@mx) {
            print GOODADDR "$add\n"; #address is good
            }else{
            print BADADDR "$add\n"; #address is bad
        }
       
    $pm->finish;
}

close (GOODADDR);
close (BADADDR);

[download]

This code works. The only thing I noticed is that the parent will finish before some of the children (is that terminology correct?). If someone was impatient they would think the program is done when actaully it may need another minute to finish. Can this be prevented?

Neil Watson
watson-wilson.ca

In reply to Re: Fork Me I need help by neilwatson
in thread Fork Me I need help by neilwatson

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.