It's hard to know exactly, but I think your problem is here: 

foreach $pair (@pairs) 
{
($key,$value) = split (/=/, $pair);
  chomp ($value);
 
   foreach $name (@names) 
   {
    $name =~s /\s$key/$value/ig;
    @newrecords = (@newrecords,"$name");
   }
}

[download]

This code recompiles the regular expression on every execution. Perl doesn't know that it only changes on every pass through the outer loop. I would replace it with something like this: 

foreach $pair (@pairs) {
  ($key,$value) = split (/=/, $pair);
  chomp $value;

  # compile pattern to match $key with qr//
  my $match = qr/\b\Q$key\E\b/;

  # serach and replace names and push onto @newrecords
  foreach (@names) {
    s/$match/$value/gi;
    push @newrecords, $_;
  }
}

[download]

This version also incorporates the eariler good advice concerning \b, \Q, \E and push().

If that doesn't help you, consider slowing down and analyzing the performance of your program. Use Devel::DProf and/or Benchmark to get a better idea of how your code performs and where the time is being spent. Performance problems are very hard to solve by guessing.

-sam

In reply to Re: Simply Too Slow Find and Replace by samtregar
in thread Simply Too Slow Find and Replace by guopan

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.