opendir(DIR, $directory) || die print "Couldn't open directory"; my @unscont = sort grep !/^\.\.?$/ && !/\.gif$/, readdir(DIR); closedir(DIR); @files = grep(/\./, @unscont); @dirs = grep(!/\./, @unscont); for my $file (@files) { print qq[ <a style="{font-size: 13px; color: #000000;"} href="./$ +this?func=read&file=$file&dire=$dire">$file</a><br>\n]; }
Note the use of grep to sort out all entries consisting of a single or double dot and those ending in .gif right off the bat, then shuffling it through sort so that you don't have to call sort twice to sort the lists of files and directories individually. You can also write that separation into @files and @dirs as (/\./ ? push @files, $_ : push @dirs, $_) for @unscont;thus finishing the job with a single pass through the list. Lastly, /\./ is a really lousy form of checking for directories because who's to say a file has to have a dot in its name, or that a directory cannot have one? Instead, use the -d operator as in
my @dirs = grep -d "$directory/$_", @unscont; my @files = grep ! -d "$directory/$_", @unscont;
(Or as part of my push proposition; that shall be left as an excercise to the reader.)

Makeshifts last the longest.


In reply to Re: noshow by file extension by Aristotle
in thread noshow by file extension by einerwitzen

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.