my $format = "foo (bar] baz"; eval '$regex = qr/$format/;'; die "ack - $@" if $@;
Danger! Danger! If $format contains a slash, that ends the regex and begins Perl again.

I think you were trying for this:

my $format = "foo (bar] baz"; eval { qr/$format/ }; die "ack - $@" if $@;
Which won't matter if it contains slashes. Almost every code that contains string-eval is broken, and almost never necessary. {grin}

-- Randal L. Schwartz, Perl hacker


update: Oh duh. Didn't see the single quotes. In which case, it's overkill, but not dangerous as-is, except that it can be misleading as to why you used single quotes and run-time eval-string instead of compile-time eval-block.

In reply to • DANGER! Re: Re: How to identify invalid reg. expr.? by merlyn
in thread How to identify invalid reg. expr.? by armyk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.