Yeah, there are simpler ways to keep a list of IPs. As the list grows, time to check them increases tremendously.
If you really must do it this way, use a database. Even something simple like DBD::CSV would help immensely.
Specific things in your code that I'd do differently are:
- Error checking (always check the return value of open calls!)
- Open the IP list for appending, at least. ">> listofips.txt". That way, you don't have to write the whole thing at once.
- Setting $/ to undef and slurping the whole file into a scalar instaed of using read.
But tracking IP addresses really isn't the way to go here, as
merlyn and others have pointed out.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.