Ok, I'm not too good at this, so I thought this might be a good time to practice then. I found a few things I found curious, although I can't be 100% sure they are wrong, so I'll just post them and see if I hit any marks. :)

Here's one I am not sure about: 

open(OUTPUT,">>$outputFile");

[download]
I would, at a wild guess, think that if uploading resumés, and with the same name, they would, if anything, replace the old one - or be disallowed. This appends to an earlier file, which just seems wrong. I can guess the file will be deleted when this script is done, but this allows for strange effects. Using a unique temporary name would have been better, if the file should not stay there, or to check for duplicates if it should stay. File locking could be yet another way to go.

This, I wonder if it may have other implications elsewhere? 

$CGI::DISABLE_UPLOADS      = 0;          # Temporarily reenable up

[download]
I'm not really sure how this works with CGI.pm and all, or how the rest of the code/system looks, but maybe a "local" would have helped?

I don't get this one either: 

if ( $stats[7] > MAX_FILE_SIZE || %errors ) {
  $errors{'file_size'} = ["","","Your submitted file's size is over 3M
+B."];

[download]
If there are errors, you automatically have too big file size? That ought to confuse a few... :)

This is an odd check: 

if( $file_type =~ /octet-stream/ ) { 
  $errors{ 'file_type' } = ["","","Unrecognize your submitted resume f
+ile format."];
  goto Print;
}

[download]
There must be more non-allowed file types, or did he mean "!~"?

I'm sure I missed all the real errors, and pointed out perfectly legitimate stuff, but if that is so, I hope to learn something from the grind-my-face-in-the-ground treatment I am gonna get. :)

You have moved into a dark place.
It is pitch black. You are likely to be eaten by a grue.

In reply to Re: strict isn't everything by Dog and Pony
in thread strict isn't everything by Ovid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.