Let me start with the most obvious issues:
- The lines
%file2 = 'Source.txt' ;
open(INFO, "<%file2" ) ;
is incorrect. You should use a '$' here, not a '%', since file2 is holding a simple string. For that matter, you could reuse $file1 from the previous block of code, or do without storing the filename in a variable altogether:
open(INFO, '<Source.txt');
- You're not verifying that any of the open() calls succeeds.
- You're not removing end-of-line characters from any of the lines you're reading.
- You're comparing strings containing only IP addresses (from the first file) to strings containing IP addresses and country names (from the second file). You're unlikely to find any matches.
I would be inclined to use a hash to store the table of IP addresses and countries. You'd construct the hash something like this:
my %table;
open(IN, '<Source.txt') or die;
while (<IN>) {
chomp;
my($ip, $country) = split(' ', $_, 2);
$table{$ip} = $country;
}
You'll have to make sure that split() call correctly splits your input data into IP and country name, of course.
Once you've done that--and assuming you've removed newlines from your input data--you can do country lookups like this:
open(OUT, '>>conversion.txt') or die;
foreach $line1 (@lines1) {
if (exists $table{$line1}) {
print OUT $line1, ' ', $table{$line1}, "\n";
}
}
close OUT;
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.