Thanks for the tip on allowing someone to specify their own sendmail. I didn't realize the huge security issue involved with that. I'll be sure to make changes on that asap.

return defined $thing and length $thing ? 1 : 0;

What exactly does this do? Is this one of those awkward ways to write an if statement as in old-style C? What is the purpose of the ? 1 : 0?

Finally, what do you have against CGI.pm? I'm looking for both reasons to use it and reasons not to use it. You obvioulsy have a strong opinion in one direction.

Note for PM regulars: no, I still don't like CGI.pm, but I thought it'd be a lot better than the current solution.

In reply to Re: Re: Some suggestions on coding style - a chance to critique by emilford
in thread Some suggestions on coding style - a chance to critique by emilford

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.