Sibling monks have alluded to this but not quite spelt it out: I'd strongly encourage you to Use More Modules.

Even in this small script you could save yourself some lines of code, improve readability, increase flexibility and guard against snafu, by using Mail::Sendmail.

And of course (I mean *of course*) you could be using CGI.pm *much* more. The whole of parse_form() would become redundant, just to start with.

There's such a wealth of good work in CPAN; and of course there is some time to be spent learning how to use each new module; but you get that time back almost at once as the module speeds up your work.

And learning to use a module puts you in the way of looking over some of the best code around, which does no harm to one's programming style.

§ George Sherston

In reply to Re: Some suggestions on coding style - a chance to critique by George_Sherston
in thread Some suggestions on coding style - a chance to critique by emilford

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.