This traverses the whole tree, and every time there's a match, pushes the current node to this array.
This sounds like a case for having the array as a property of the Tree object as it is a property which relates directly to the object. At the very least you could use a lexical over package variable as it isn't needed in your case.
But I have a feeling I'm breaking some fundamental OO rules, or maybe this is an example of a ghastly global variable?
I think if you're just writing a small program then it's alright to have somewhat messy OO as long as you're sure it's just a throwaway script. Much like using strict it's a good habit to get into applying proper OO structure to your programs consistently so that your skill remains honed and you're less likely to slip up in future.
HTH

_________
broquaint

In reply to Re: Global variables by broquaint
in thread Improper use of global variable? (was: Global variables) by Basilides

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.