Well, lets say you dont want to use a global variable, suppose your binary tree is composed of hash elements with "left" and "right" keys (where left<=mid<right) you might try something like this:
sub find_key_dupes { my $binary_tree=shift; my $key=shift; my $sub; my @dupes; $sub=sub { my $node=shift; return unless $node; if ($node->{key} lt $key) { $sub->($node->{right}); } else { push @dupes,$node if $node->{key} eq $key; $sub->($node->{left}); } }; $sub->($binary_tree); return \@dupes; }
This is using closures to simulate the effect of a Pascal's nested subroutines. Its a nice trick for having lexically scoped vars acting as globals to a recursive subroutine. This avoids having to pass them as parameters. Also, my guess is that you could avoid recursion entirely and do this with one sub (without nesting) using iterative techniques, which would be faster but probably slightly more complicated code.

Oh and I whipped that code out pretty fast, so its untested but you get the idea I hope. (And I hope its correct ;-)

Yves / DeMerphq
---
Writing a good benchmark isnt as easy as it might look.


In reply to Re: Global variables by demerphq
in thread Improper use of global variable? (was: Global variables) by Basilides

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.