How about something like:

# default
$Max_Questions = $Total_Questions
  unless defined $Max_Questions;

# check boundaries
croak "Number of questions in $FileName exceeded"
  if $Max_Questions > $Total_Questions;
croak "Must have at least one question in the test"
  if $Max_Questions < 1;

# good to go
&_set_Max_Questions($self, $Max_Questions);

[download]

Update: D'oh! Corion beat me to it... but I like croak ... if better than if ... croak in this case; I think it makes it more obvious that the boundary checks are error conditions, rather than correctable "mistakes" (like undefined $Max_Questions).

Update 2: Fixed syntax error... thanks TStanley.

--
The hell with paco, vote for Erudil!
:wq

In reply to Re: Optimization of a piece of code(Is there a better way than this?) by FoxtrotUniform
in thread Optimization of a piece of code(Is there a better way than this?) by TStanley

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.