I prefer this: 
my %total;
while ( my $data = $t_sth->fetchrow_arrayref ) {
    my ( $amt, $id ) = @$data;
    $total{$id} += $amt / PRECISION;
}

$tcash        += delete $total{$CASH}        || 0;
$taccount     += delete $total{$ACCOUNT}     || 0;
$tcheck       += delete $total{$CHECK}       || 0;
$tgift        += delete $total{$GIFT}        || 0;
$tvoucher     += delete $total{$VOUCHER}     || 0;
$tcc_man_auth += delete $total{$CC_MAN_AUTH} || 0;

$tcredit += $_ foreach values %total;

[download]
Slightly longer, but much more straightforward. (Although I did need the || 0 bits to make it quiet under warnings.) And, of course, all of the variables following a naming pattern suggests that you would be better off using a hash...

BTW I hope you learned that using short-circuting conditionals as a control structure is a bad idea.

In reply to Re: Pop quiz: find the bug by Anonymous Monk
in thread Pop quiz: find the bug by Ovid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.