I agree that there are security issues that need to be addressed here. One thing that I didn't see at that link that Joost mentioned here ('cause it's not really a CGI issue) is the use of system.

The OP is using the single-argument form, with part of that argument taken directly from the form input. Bad Idea. Use the multiple-argument form of system after validating the form input, that each variable contains only data that's expected:

system ("/var/www/perl/cgi_classification.pl", $outfile, $input_sequen +ce, $name);

This line looks hairy, as well:

open OUTFILE, ">/var/www/data/$ARGV[0]" or die "cannot....";
I don't know whether $ARGV[0] is tainted, but I'd validate it before opening, anyway.
my $filename = $ARGV[0]; # Use whatever regex suits your needs. this is just an example. if ($filename =~ /^([\w]+\.[\w]+)$/) { $filename = $1; } else { # handle the error here }

HTH

--

There are 10 kinds of people -- those that understand binary, and those that don't.


In reply to Re: running a perl program from a cgi webpage by mephit
in thread running a perl program from a cgi webpage by Becky

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.