*laughs* ref($cargocult) || $cargocult; Very nice! :-)

Otherwise, it all looks fine. You've got a lot of the idioms I would use in an OO situation.

A few ideas to bring (and boggle) you further:

  1. Use closures to generate the accessors in Expense. 
    sub new {
    # Stuff up here
    foreach my $attrib (keys %$self) {
        my $conv_attrib = $attrib;
        $conv_attrib =~ s/^_(\w+)$/lc $1/e;

        no strict 'refs';
        *{__PACKAGE__ . "::$conv_attrib"} = gen_closure($attrib);
    }
    return $self;
}

sub gen_closure {
    my $attrib = shift;

    return sub {
       my $self = shift;
       if (@_) { $self->{$attrib} = shift; }
       return $self->{$attrib};
   }
}

    [download]
    That is much easier to maintain when you start hitting 20 or 30 attributes in your objects.
  2. Look at separating your database logic from your business logic. This is something we're hitting where I work right now. It'll sound crazy, but if this is going to scale, you will need to do that. Maybe something along the lines of DB::Expense so that if your database schema changes (which it will), you aren't left scrambling to fix your beautiful OO structures.

Good luck!

------
We are the carpenters and bricklayers of the Information Age.

Don't go borrowing trouble. For programmers, this means Worry only about what you need to implement.

In reply to Re: My first stab at OO perl... by dragonchild
in thread My first stab at OO perl... by Theseus

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.