I don't have any clever map sort or grep approaches, but the
code could be simplified. For the sequence of if-then
statements, one could use
my @institutions = qw|hospital1 hospital2|;
my %seen;
$seen{$_}++ foreach @institutions;
if (!defined $institution) {
$institution_table{"unaffiliated"} ++;
} elsif (exists $seen{lc $institution}) {
$institution_table{lc $institution} ++;
} else {
$institution_table{"other"} ++;
}
For the loop, here is a slightly more clever method:
my $cat_age = int ($age/5) - 9;
my @age_cats = qw|fortyfive_fifty fifty_fiftyfive fiftyfive_sixty|;
foreach (keys %institution_table) {
$institution_table{ $_ }{ $age_cats[$cat_age] }++;
}
One could use a map for the loop, but the foreach is faster.
-Mark
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.