Greetings andrew,

Always use strict. Thereafter, I'd prepare the second query outside the while using a different name than your first. With DBI, you can have multiple queries running this way. Also, bind values (also known as placeholders) via DBI are your friend.

use strict;
my $sth_null = $dbh->prepare(q{
  SELECT id, name FROM category WHERE parent IS NULL
});
$sth->execute or die $dbh->errstr;

my $sth_parent = $dbh->prepare(q{
  SELECT id,name FROM category WHERE parent = ?
});

while ( my @slog = $sth_null->fetchrow_array ) {
  $sth_parent->execute($slog[0]) or die $dbh->errstr;
  my $rv = $sth_parent->rows;
  my $subs = $rv;

...

[download]

Using placeholders with your prepare and execute statements lets DBI deal with making sure quotes are handled correctly. It also makes for nicer looking code, IMHO.

-gryphon
code('Perl') || die;

In reply to Re: Using Multiple Statements MySQL by gryphon
in thread Using Multiple Statements MySQL by andrew

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.