You have bigger problems than the length of your code.

You should use strict.pm. Get rid of your globals. Using select * in anything that you don't want to break is silly. Using it with positional logic means that you don't want to understand your code, you don't want anyone else to either. Plus you had better be planning on rewriting it in a hurry at the worst possible time. Because you will have to whenever someone rebuilds the database table and moves columns around on you. Fixing all that is a minimum.

And just in case you have bought into the peculiar stupidity which says that unreadable code provides "job security", it doesn't. Deliberately produce crap, and it will be cheaper for your employer to fire you and rewrite it. The sooner the better so that you have produced less to rewrite. (They admittedly often don't realize this fast enough.)


In reply to Re: shortin this code up by Anonymous Monk
in thread shortin this code up by andrew

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.