Nice work. Lets add a bit of holistic consideration. What exactly is he trying to achieve? well, very simply it's a plural translation within english. In those instances where more than one system is down, he wishes to maintain a correct english sentence.
We thus minimise our code duplication like this (perl):
open(MAIL,"|mailx blah") || die "No mail stuff: $! \n";
if ($ct>0) {
print MAIL "\n$ct ".($ct>1 ? "are not available" : "is down")." at
+ this time.\n";
}
close(MAIL);
But of course the greatest optimisation is always achieved by considering the whole problem, not just the perl:
open(MAIL,"|mailx blah") || die "No mail stuff: $! \n";
print MAIL "\nSystems unavailable at this time: $ct\n" if ($ct>0)
close(MAIL);
Silly I know, but to the point: Good optimisation looks at the whole problem.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.