Any comments are welcome :-)

Three comments:

1. Taint check. If someone sneaks Javascript into a cookie, they've set you up for a "cross-site scripting attack" (i.e., you'll end up emitted their javascript in your page).

2. The fragment

$content = $query->cookie('user'); @new = split ("=", $content);
should set you up for a one-trip loop, since the value you get back shouldn't have "=" signs embedded unless they're a legal character in the cookie value. You should be able to get by with   $user = $query->cookie('user'); 3. Mixing hand-coded HTML with HTML generated by CGI is confusing, and could complicate maintenance. Either use templates, or go all the way with CGI methods.


In reply to Re: Pulling out the value of a cookie: Revisited by dws
in thread Pulling out the value of a cookie: Revisited by WarrenBullockIII

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.