I think the subs are useful but hossman is right about how you set the subs up
Here's a sample script that I came up with and maybe you can tinker with it a little so you can have two flavors, this code did work on linux but I only recently tested in windows Xp, hope it helps!
#!/usr/bin/perl -w use strict; my $choice = ""; # main program while ($choice !~ /q/i) { $choice = &mainmenu(); SWITCH: { $choice =~ /^1/ && do { &option1(); last SWITCH; }; $choice =~ /^2/ && do { &option2(); last SWITCH; }; } } # main menu sub mainmenu { my $input = ""; print "\nUTILITIES\n\n"; print "Please choose from the following options (or Q to quit):\n\ +n"; print "1. Establish PPP Session\n"; print "2. Logoff\n"; print "-------------------------\n"; while () { print "\nYour choice --> "; chomp($input = <STDIN>); if ($input =~ /^\d$/ || $input =~ /^q$/i) { return $input; } else { print "Not a choice. 1-2 or Q to quit, please,\n"; } } } # connect to PPP session sub option1 { print "Connecting to PPP session\n"; } # log off session sub option2 { print "Logging off\n"; }

In reply to Re: Re: Shell Menu Code Review by softworkz
in thread Shell Menu Code Review by PrimeLord

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.