I think that version of formmail is safe from poison null byte expoloits. Perl itself doesn't treats null byte specially. It have special meaning only to system libraries so it can be exploited only when you pass filenames with null byte to functions like open.

I've made quick review of that code and I have found only two open calls. Both of them do not use user supplied input for filenames.

Read this Phrack article which describes how poison null byte expoloits work.

Update: On the other hand I see that user supplied data is feed to sendmail as it is without escaping any bad chars (watch for print MAIL lines). It seems it can be used to inject additional mail headers into message. I'm not sure how it can exploited.

Also there are XSS issues. It seems that user input is used to render HTML page without escaping any bad chars. Even if it is true it is unlikely to be exploitable since only user who submits form sees that page. Still it stinks.

--
Ilya Martynov (http://martynov.org/)

In reply to Re: Poison null byte test by IlyaM
in thread Poison null byte test by simon.proctor

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.