print "Welcome $username\n\n";
        print "Please chose from the following options:\n";
        print "1) Establish PPP Session\n";
        print "2) Logoff\n";
        print "------------------------\n";
        print "Choice: ";

[download]
One thing that shows up again and again are blocks of print statements like this; and of course Perl has an easier way for you to do it. For instance, you can chain print statements together with commas: 
        print "Welcome $username\n\n",
         "Please chose from the following options:\n",
         "1) Establish PPP Session\n",
         "2) Logoff\n",
         "------------------------\n",
         "Choice: ";

[download]
And of course Perl will allow you to get rid of all those extra quotes and commas: 
print "Welcome $username

Please chose from the following options:
1) Establish PPP Session
2) Logoff
------------------------
Choice: ";

[download]
Or probably even better, use a HERE doc 
print <<EOP;
Welcome $username

Please chose from the following options:
1) Establish PPP Session
2) Logoff
------------------------
Choice:
EOP

[download]

In reply to Re: Shell Menu Code Review by Sifmole
in thread Shell Menu Code Review by PrimeLord

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.