my $key = $institution
          && ($valid_institution{lc($institution)} || "other")
          || "unaffiliated";

[download]
When I'm doing code review for hire, I do not permit using testthing && truething || falsething in production code unless there's also a big comment in the margin that says literally: 
## I'm promising that the true branch here can NEVER EVER EVER
## return a false value, which would have caused the
## false branch to be erroneously executed.  If you're
## updating this code, please continue to maintain
## this precondition, which I have placed precariously
## and needlessly in this code. Have a nice day.

[download]
If you don't want to add a big friggin' comment like that, then change the very dangerous broken and-or construct to the entirely safe testthing ? truething : falsething, as in: 
my $key = $institution
          ? ($valid_institution{lc($institution)} || "other")
          : "unaffiliated";

[download]

-- Randal L. Schwartz, Perl hacker

In reply to •Please don't use foo && truething || falsething by merlyn
in thread an easier way with grep, map, and/or sort? by aufrank

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.