That function isn't very graceful, especially with that repetitive shifting and data duplication. Here's how you could rewrite it:
process($data_ref, \@set_up, $template, $fd_out);
sub process
{
my ($data, $set_up, $template, $fd_out) = @_;
foreach my $record (@$data)
{
# ...
}
}
Maybe it's just me, but I find reading function arguments with
shift is usually pointless since you can just declare the works in a single line. It's also nice to have the function argument declaration in a similar format to how you call it, so you can see if things match up.
As of Perl 5.6 or thereabouts, you can open a filehandle that is put into a scalar (glob reference) using the
open function:
my $fd_out;
open($fd_out, $what_file);
while (<$fd_out>) { # ... }
Or, of course, there is always
IO::File:
my $fd_out = IO::File->new($what_file, 'r');
while (<$fd_out>) { # ... }
These filehandles are a lot easier to pass back and forth than the regular globs. If you're even thinking about using them as function arguments, don't use globs.
As a note:
${$foo} and
$$foo are equivalent. It's often simpler to just leave off the extra braces since they don't serve any practical purpose. There are occasions like
${$foo->{bar}} where they more appropriate.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
|
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.