You are right that there is a better way to build the command argument array. Your can assign the array as a list, the variable values don't need to be quoted, interpolating quotes are unneeded for constant values,and your trinary operator is a bit clumsy. I suggest this:

my $buildcmd    = "/path/to/foo/binary";   
my @buildcmd = ( '-p', $workpath,
                 '-P', $workpath,
                 '-H', $pl_url,
                 "--maxdepth=@{[$maxd < 3 ? $maxd : 2]}");
push @buildcmd, "--bpp=$bpp" if $bpp;
push @buildcmd, "--$compr-compression" if $compr;
push @buildcmd, ('-N', $title,
                 '-V3',
                 '-f', "$workpath/$md5file");

[download]
The trinary in $maxd is probably unnecessary if you have already checked that in validation. Having validation fail on missing required values can likely be done by checking one of existance, definedness or truth for required keys in the %template hash.
my @need = grep { $template{$_} } qw( url maxdepth filename);</p>

[download]
Adjust to need with extra keys, exists, defined, etc. Testing against values in a hash of regexes over the same keys would be an elegant way to get validation and untainting done at the same time.

After Compline,
Zaxo

In reply to Re: Email "Reflector" design snags by Zaxo
in thread Email "Reflector" design snags by hacker

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.