I assume you want to set the value if a parameter is passed or if the current value is undef, and just return the current value otherwise:
sub balance_by {
  my $self = shift;
  my %valid_params = map {$_ => 1} ('foo',
                    'bar');

  if (@_ or ! defined $self->{'balance_by'}) {
    my $entry = shift;
    $self->{'balance_by'} = 
        (defined $entry and $valid_params{$entry})
            ? $entry 
        : 'foo';
  }
  return $self->{'balance_by'};
}

[download]
I would also define your %valid_params outside of the subroutine. No need to define them each time you call the sub. Also if you want to nano-optimize your code, consider using exists to see if the key exists in valid_params instead of testing its value, like so:
my %valid_params; undef @valid_params{qw(foo bar)};
...
(defined $entry and exists $valid_params{$entry})
...

[download]
Also, unless I'm mistaken, there doesn't seem to be any reason to not default your fields in the 'new' method...(unless you just wanted 'if (@_)...' in that conditional?)

In reply to Re: only allow certain parameters by runrig
in thread only allow certain parameters by aufrank

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.