The problem in your is with extracting the sub parms from  @_. With 
  my $file_name = ${shift()};
  my $lines_in  = ${shift()};

[download]
you are copying your dereferenced references into new local variables, which does not update the variables in the caller. Try instead 

sub read_template {

  my $file_name = shift;
  my $lines_in  = shift;
  my $line_cnt  = 0;

  if (!open (INPUT, "< $$file_name")) {
    die "Can't open $file_name as input.";
  } else {
    while (<INPUT>) {
      $line_cnt++;
      $$lines_in .= $_;
    }
    close (INPUT);
  }
  return($line_cnt);
}

[download]
This approach keeps the references and updates the caller's variables.

-Mark

In reply to Re: Sub Params as references by kvale
in thread Sub Params as references by Maclir

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.