is there a better way to make the searching faster?

Indeed there is. You can do away with the inner foreach loop (and a lot of regex recompiling) by constructing a regex and compiling it once. Change 

  while ($data = <DB>) {
    chomp($data);
    foreach $id (@id) {
      if ($data =~/$id/) {
        print OUT "$data\n";
      }
    }
  }

[download]
to 
  my $regex = '(?:' . join('|', @id) . ')';

  while ( $data = <DB> ) {
    print OUT $data if $data =~ /$regex/o;
  }

[download]
The (?: ... ) surrounding the regex is to avoid setting $1 as a side effect. This saves a tiny bit of work.

The /o modifier on the regex invocation says to compile the regex once (a big win). Bye bye, inner loop.

Note that you also do away with the chomp(), since it doesn't affect the regex, and you'll need a newline on the end of the string anyway.

In reply to Re: need more efficient way to write this query script by dws
in thread need more efficient way to write this query script by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.