It's probably better to name your libraries '.pm' instead of '.lib'. Not only can they then be 'use'd properly, but it's really better to conform to existing standards than to invent your own.

One of the problems with eval is that it can hide errors. Don't forget to check $@ for anything you might have missed.

Also, in the context of your gethash function you can use an actual hash, and return a reference to it. Saves having to dereference repeatedly. With a tiny bit of tweaking, you get:
# hash.lib # in the library sub gethash { my %hash; open(FILE, "data.txt") || die "Can't open data - $!\n"; # dick:98 # robert:76 # mary:68 chomp(my @lines = <FILE>); close(FILE); foreach (@lines) { my ($name,$score) = split /:/, $_; $hash{name} = $name; $hash{score} = $score; } return \%hash; }
More tweaking produces:
# hash.lib # in the library sub gethash { open(FILE, "data.txt") || die "Can't open data - $!\n"; my %hash = map { (split(/:/))[0,1] } chomp(<FILE>); close(FILE); return \%hash; }

In reply to Re: Using my and library.... by tadman
in thread Using my and library.... by kiat

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.