From your code, it looks like you are only getting the last entry in your file:
foreach (@lines) { my ($name,$score) = split /:/, $_; $hash_ref->{ 'name' } = $name; # replaces the old 'name' entry $hash_ref->{ 'score' } = $score; # replaces the previous 'score' + entry }
I might suggest using an array ref for each entry, or maybe an array of hashrefs or a hash of hashrefs. Examples:
##Array of Hashrefs: my @entries; for (@lines) { # as someone once said ~if you plan to explicitly use $_ everywhere, + you might as well give it a more meaningful name or not use it at al +l.~ my ($name,$score) = split /:/; $hash_ref->{ 'name' } = $name; $hash_ref->{ 'score' } = $score; push (@entries, $hash_ref); } return( @entries); } ##Hash of Hashrefs: for (@lines) { my ($name,$score) = split /:/; $hash_ref->{ $name }{'name'} = $name; $hash_ref->{ $name }{'score'} = $score; } return($hash_ref); } ##Hash of Arrayrefs: for (@lines) { my ($name,$score) = split /:/; $hash_ref->{ $name } = [$name,$score]; } return($hash_ref); }
I could come up with several more data structures to store the same data but you get the idea. TMTOWTDI and as I like to always say, see whatever works best with your program and go with that.

In reply to Re: Re: Re: Using my and library.... by smalhotra
in thread Using my and library.... by kiat

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.