Although the comment there says "accessors" those don't look anything like accessors. It looks like code to add members to an object rather than to retrieve or change the value of those members.

Is all of the code you pasted in the same module? If so, I'd say it isn't all that bad except for the fact that it is counterintuitive, inefficient and seems to come from a misunderstanding of encapsulation. This would probably be better:

push @{$self->{_fields}}, $field; 
$self->{_fields_hash}->{$field->fullname()} = $field;

[download]

If by "elsewhere" you mean somewhere not in the same module, then it's downright terrible.

-sauoq
"My two cents aren't worth a dime.";

In reply to Re: accessor abuse..? by sauoq
in thread accessor abuse..? by Jasper

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.