# First suggestion: add error checking.
open (ONE, $file1) or die "Couldn't open $file1: $!\n";
open (TWO, $file2) or die "Couldn't open $file2: $!\n";

# 2nd suggestion: check syntax.
while ($line1 = <ONE>) { 

    # 3rd suggestion: eliminate unneeded loops.
    $line2 = <TWO>; 

    # 4th suggestion: don't chomp if you don't need to.

    # 5th suggestion: If you don't need the whole array, don't keep it
+.
    $element1 = (split ' ', $line1, 2)[0];  
    $element2 = (split ' ', $line2, 2)[0];

    # 6th suggestion: Handle either or both cases. 
    if ($element1 ne $element2) {  
        print "$element1 does not equal $element2 at line $.\n"; 
    } else {
        print "$element1 is the same in both files at line $.\n";
    }
}

[download]
-sauoq
"My two cents aren't worth a dime.";

In reply to Re: comparing files by sauoq
in thread comparing files by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.