For generating passwords, you might want to take a look at spew - print out random characters, which will generate the desired number of random characters from the set of characters you choose.

Your "two weeks in the future" code could be more tightly written as:

use constant WEEK => 60 * 60 * 24 * 7;
my $expiry_date = sprintf '%04d-%02d-%02d',
  sub { $_[5]+1900, $_[4]+1, $_[3] }->(localtime(time + 2 * WEEK));

[download]

The code to update the postfix virtual table looks possibly more complicated than it should be, but I'm not clear on your intent. What are you trying to do?

You should use Mail::Sendmail (which, despite its name, does not rely on sendmail(1)), or another mail sending module, rather than attacking the sendmail program directly. Instead of a row of print statements, you should use a heredoc:

print MAIL <<"END_OF_MAIL";
To: bar\@foo.com
Reply-to: $email
From: $email
Subject: AP3k New User Signup

Test Mail1

END_OF_MAIL

[download]
All Of The Variables Have Been Sanitised By Another Perl Script

That means nothing. You should re-sanitise them again in this script.


print@_{sort keys %_},$/if%_=split//,'= & *a?b:e\f/h^h!j+n,o@o;r$s-t%t#u'

In reply to Re: Desperate Coding Tidy-up by grinder
in thread Desperate Coding Tidy-up by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.