Monks,

I am having a few problems with my script for editing postfix files. It looks a bit on the messy side and i was wondering if any of you could think of a cleaner way of doing the below. Here Is The Code: 
my $datafile = '/etc/postfix/virtual';
my $req_addr = "$username\@$domain";
my ( $name, $domain ) = $req_addr =~ /^([\w.-]+)(@[\w.-]+)$/ ;
open FH, $datafile or die;
my @virtual = <FH> ;
close FH ;
open FH, ">$datafile" or die;
my $wrote_it = 0 ;
for ( @virtual )
{
  print FH $_ ;
  if ( $_ =~ /$domain/ && !$wrote_it )
  {
          print FH "$req_addr\t$username\n" ;
    $wrote_it++ ;
  }
}
close FH ;

[download]
Here Is The File: 
test.com        VIRTUALDOMAIN #defines the domain name
@test.com       jnapier #defines the postmaster of domain
idunno@test.com idunno #just a regular user

other.com        VIRTUALDOMAIN #defines the domain name
@other.com       jnapier #defines the postmaster of domain
iknow@other.com  iknow #just a regular user

[download]
I have the following variables $username which contains the users name (in this case idunno, or iknow), and $domain (in this case test.com or other.com).

The script needs to open the /etc/postfix/virtual file, using whats in $domain, seek to the line that defines the domain name, move down past the line that defines the postmaster of the domain, and dump $username\@$domain\t$username just below that, so it basicaly adds another regular user.

Thanks

In reply to There has got to be a Cleaner Way! by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.