There are a couple of stylistic points that I'd like to make about your code - one more serious than the other.

The more serious one is that you're using array slices where you want scalars. That is where you're using @local_tm[2] you should be using $local_tm[2].

The less serious issue is that you don't need to split up the parameters to print. You can do something like this:

print "$local_tm[2]:$local_tm[1]:$local_tm[0] $tz\n";

[download]

or (to get the formatting a little nicer) you can use printf:

printf '%02d:%02d:%02d %d', $local_tm[2], $local_tm[1], 
                            $local_tm[0], $tz;

[download]

or (to really show people how well you know Perl) use printf and an array slice:

printf '%02d:%02d:%02d %d', @local_tm[2, 1, 0], $tz;

[download]

--
<http://www.dave.org.uk>

European Perl Conference - Sept 22/24 2000
<http://www.yapc.org/Europe/>

In reply to RE: RE: Timezones in Perl by davorg
in thread Timezones in Perl by ArthurDent

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.