foreach $field (@fields){
       ${$field}  = $q->param($field);
       ${$field}  = filter(${$field});
       $record   .= "\::${$field}";

                      }

[download]

First off, unless you really need to save the $field data for later, you don't need to setup the ${$field} variables. You could do...

foreach $field (@fields) {
    $temp = $q->param($field);
    $temp = filter($temp);
    $record .= "\::$temp";
}

[download]

Secondly, If you did need to save the data as such for some reason... Use a hash.

foreach $field (@fields) {
    $data{$field} = $q->param($field);
    $data{$field} = filter($data{$field});
    $record .= "\::$data{$field}";
}

[download]

The person who helped me learn perl told me "If you're dealing with data, always ask How can I use a hash here?"

In reply to Re: trouble modifying add_record subroutine by anithri
in thread trouble modifying add_record subroutine by cal

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.