It's difficult to tell what the error is if you don't supply us with the actual error message. If the file is on a network file system, flock is unlikely to work. Further, flock is a polite way of requesting that others leave the file alone. It does not actually stop the file from being used by someone else unless they check to see if it's locked. (That's probably not relevant to your question, but I thought I would mention it).

Here's a somewhat cleaner version of your code (straight from the Perl Cookbook): 

use Fcntl qw(:DEFAULT :flock);

sysopen(FH, $file_banner, O_RDWR|O_CREAT) or die "Can't open $file_ban
+ner: $!\n";
flock(FH, LOCK_EX)                     or die "Can't write-lock $file_
+banner: $!\n";
$num = <FH> || 0;                      # do not use 'or' here
seek(FH, 0, 0)                         or die "Can't rewind $file_bann
+er: $!\n";
truncate(FH,0)                         or die "Can't truncate $file_ba
+nner: $!\n";
print FH $num+1, "\n"                  or die "Can't write to $file_ba
+nner: $!\n";
close(FH)                              or die "Can't close $file_banne
+r: $!\n";

[download]
Note that the above code will create the file for you if it does not exist. Thus, the if/else structure is eliminated.

Hope this helps.

Cheers!

In reply to Re:What is the best way to lock a counter file? by Ovid
in thread What is the best way to lock a counter file? by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.