As a matter of style I'd move your html generation out in templates and use something like HTML::Template or Template::Toolkit. You have the advantage of editing the look and feel of your HTML without the risk of accidently modifying your code.

$q->a({-href=>"emp-list.cgi?sort=emp_id"}

Consider something like $query->url(-full=>1); this way you can change the name of your CGI without having to hunt thru' your code to find the references to your hardcoded (tm) script name.

Personally, if i were producing the above i would abstract the database routines into a seperate module make the call, return the data, then turn it into html. You have the advantage of reusable code, and a single maintaince point.

In reply to Re: A Matter of Style in CGI by Ryszard
in thread A Matter of Style in CGI by Spenser

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.