Much improved.

I think exit $files_done == 0; is equivalent to exit($files_done) == 0 rather than exit ($files_done == 0) which is what you want.

Also, ... or (warn "Couldn't open $_: $!\n", next); won't work as expected. You want ... or warn("Couldn't open $_: $!\n"), next; there. That one caught me off guard. I didn't catch it till I ran it.

When I ran it (5.6.1), I also got this warning: Parentheses missing around "my" list at ./htr_a2 line 17. Line 17 is your read. Throwing parens around read's args eliminates the warning.

I fixed the error you pointed out by using eof() and reintroduced the same functionality you had. I also added a check to be sure the first argument is numeric and positive.

#!/usr/bin/perl -w
use strict;

use constant BLOCKSIZE => 128 * 1024;

my $USAGE =<<END_OF_USAGE;
Usage: $0 nbytes file [file ...]
    nbytes    Positive integer. Number of bytes to remove.
    file      Name(s) of file(s) to decapitate.
END_OF_USAGE

die $USAGE if @ARGV < 2;

my $nbytes = shift @ARGV;
die $USAGE unless $nbytes eq int(0+$nbytes) and $nbytes >= 0;

my $completed = 0;

for my $file (@ARGV) {
    open(my $fh, "+<", $file) or warn("Couldn't open $file: $!\n"),nex
+t;
    if(-s $fh > $nbytes ) {
        seek $fh, $nbytes, 0;
        my $total_in = 0;
        while(my $bytes_in = read $fh, my $buf, BLOCKSIZE) {
            my $eof = eof($fh);
            seek $fh, $total_in, 0;
            print $fh $buf;
            $total_in += $bytes_in;
            last if $eof;
            seek $fh, $nbytes + $total_in, 0;
        }
    }
    truncate $fh, tell $fh;
    close $fh;
    $completed++;
}

exit ($completed == 0);

[download]
-sauoq
"My two cents aren't worth a dime.";

In reply to Re^4: head truncate by sauoq
in thread head truncate by zentara

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.