I think you'll have a problem with the argument structure:
sub revdnacomp {
# my $dna = @_;
# the above means $dna gets the number of
# arguments in @_, since it's a scalar context!
my $dna = shift; # or my $dna = shift @_;
# ah, scalar context of scalar gives expected results.
# my ($dna) = @_; # would work, too
my $revcomp = reverse($dna);
$revcomp =~ tr/ACGTacgt/TGCAtgca/;
return $revcomp;
}
but why not allow the complementation over more than one element?
sub revcompl { # operates on all elements passed in
my (@dna) = @_;
foreach my $segment (@dna) {
my $revcomp = reverse($segment);
$revcomp =~ tr/ACGTacgt/TGCAtgca/;
push @done, $revcomp;
}
return @done; # or reverse @done; # what's best semantics?
}
Did I miss anything?
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.