print "match\n" if (/(\d{1,3})%/, $1>91);
That code has a subtle bug in it. If the regex doesn't match, $1 will still be set to its previous value...
#!/usr/bin/perl -w use strict; "abc 123" =~ /(\d+)/; $_ = "its a tub of lard"; print "'$_' matches\n" if (/(\d{1,3})%/, $1>91); __END__ 'its a tub of lard' matches
Replacing the comma with && will fix it.
if (/(\d{1,3})%/ && $1>91);
In general, don't use $1 and friends without first checking that the regex you think they belong to actually matched.

-Blake


In reply to Re: Conditionals within Regex by blakem
in thread Conditionals within Regex by jlf

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.