Nothing to add to other monks' comments, but only a few minor advices.

1. You could move the line $dir =~ s/\/$//; just a few lines up and avoid repeating the substitution if more than one .csv file is found in the same $dir. E.g.:

while ( my $dir = shift @ARGV ) {
    my $dh = new DirHandle $dir;
    if ( defined($dh) ) {
        $dir =~ s/\/$//; # Here, for example...
        while ( defined($_ = $dh->read) ) {
            if ( $_ =~ /(\.csv)$/ ) {
                push @files, "$dir/$_";
            }
        }
    }
}

[download]

2. Also, you could slightly simplify your s/// by using another delimiter, for example: s|/$||. It's not a big saving with one slash, but it's worth changing the delimiter when your pattern contains a lot of them

3. When you manipulate $_ you could want to localize it, to avoid clashes with functions or modules that use it (like File::Find, for example). It's not the case of your simple program, of course.

4. (but I guess you already know :-) if you want, you can leave out the $_ =~ from your pattern match.

Just my 0.02 EUR

Ciao!
--bronto

# Another Perl edition of a song:
# The End, by The Beatles
END {
  $you->take($love) eq $you->made($love) ;
}

In reply to Re: Combing Text Files into one file by bronto
in thread Combing Text Files into one file by dcb0127

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.