you've had a few suggestions on way to rewrite your code, but it might be useful to have a quick look at what you were doing wrong.

foreach (@lines) {

  my($month, $day, $time, $data1, $data2) = split / /;
  open(NEWTIME, $time);

[download]

Here you've tried to open a file which has the name $time. I strongly suspect that this file doesn't exist. Checking the return value from open would have told you this.

  while (<NEWTIME>) {

[download]

Having opened a file that doesn't exist, you proceed to try and read from it. If you had use warnings turned on, you would have been warned at this point. However, as the file doesn't exist is is effectively empty and <NEWTIME> won't return any data so the code in the while loop never gets executed.

    my($hour, $minute, $second) = split /:/;
    $time2 = join(':', $hour, $minute);
  }

[download]

As I said above, this code is never executed - which is why $time2 never gets set.

  select NEWLOG;
  print "$time2\n";

[download]

It looks like you're selecting a filehandle that hasn't been opened.

  open NEWLOG, ">>foofinal.txt";
}

[download]

Once more, you should check the return code from open.

--
<http://www.dave.org.uk>

"The first rule of Perl club is you do not talk about Perl club."
-- Chip Salzenberg

In reply to Re: get my variable out of the hole! by davorg
in thread get my variable out of the hole! by Bladernr

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.