This code has problems. The biggest one is that it is using global variables to pass things around between subs. This is a very messy and error-prone style. I would strongly encourage you to "use strict" and -w and to use explicitly passed variables with your subs. For example:
my $weather_template = weather();
Your loading of files would be more efficient if you slurp them up like this:
{
local $/;
open(MYFOOT,"<$foot");
my $weather_template = <MYFOOT>;
close(MYFOOT);
}
If this simple replace is really enough for your template, then go with it. However, if you see any need for fancier constructs like loops and conditionals,
please try using a module from CPAN for it.
You don't really provide enough information to determine why you are seeing code in the browser (HTML code? Perl code?), but I don't see you printing a header before sending this content. You may also have your web server or permissions set up wrong, preventing it from executing your code.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.