comment on

In looking over your code, I thought I'd just make a couple of suggestions that may help you with future programs:

You don't need to quote simple scalars to use them. For example: "$foo" can be simply $foo as the quotes are used to add things or combine scalars, such as "$foo$bar" or "${foo}s". The quotes are harmless in most cases, so it's nothing to worry about, but it looks odd.
Throwing things, like comments, around your subroutine declarations is highly unconventional. In this case, I think it degrades readability, since many are used to seeing them less decorated. You'll note that despite similar formatting, you have a case where one is a subroutine declaration, and the other is a code BLOCK.

Instead of using a constant, you might want to use a subroutine parameter. Something like this:

sub move_logs
{
     my ($logs, $target_path) = @_;
     # : (etc.)
}

# ...

my $log_path = '\\\\10.1.1.5\\Weblogiclogs\\'
               . strftime( '%y%m%d%H%M', localtime);
my $logs     = "\\\\192.168.2.5\\Weblogiclogs\\*.log";

move_logs($logs, $log_path);
[download]

One of the reasons for this restructuring is that it keeps the distance between the declaration of the variable and its use to a minimum. This makes it easier to find out what it is, without having to scroll all over the place. Imagine there was 1500 lines between the top and bottom of your program, which is not uncommon.
You may have to expand your $logs file spec into a list of files using glob and iterate over it. Something like:
```
foreach my $file (glob($logs))
{
     move($log, $log_path) || die "screaming";
}
[download]
```

In reply to Re: moving logs files on a remote share. by tadman
in thread moving logs files on a remote share. by Anonymous Monk

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.