Your use of
grep was wrong. It's for testing lists - you just wanted a single match there. The
redo isn't wrong, but can catch someone off guard. Overall the thing looks much like C. More idiomatically, it looks like this:
use Term::ReadKey;
sub Request {
my ($prompt, $letters, $linefeed) = @_;
return unless $prompt;
$letters ||= "Ny";
$linefeed ||= 1;
my ($answer, $is_correct);
do {
print "$prompt? [$letters] ";
ReadMode 'cbreak';
$answer = uc ReadKey 0;
ReadMode 'normal';
$is_correct = (index uc $letters, $answer >= 0);
print "\nplease answer [$letters]\n" unless $is_correct;
} until $is_correct;
print "\n" if $linefeed;
return $answer;
}
Note the use of uc to force things to uppercase so we needn't juggle with case-insensitivity in comparisons. You can then use it as in if(Request(...) eq 'Y') { ... }.
Update: Oops. Now complies with strict.
Makeshifts last the longest.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.