Concur.

You don't need to be a dick about it, just mention that you were interested in the guy's script, that it seemed to be taking a while, and maybe you could get together and see about making it a bit faster? If you play up your interest in the other guy's script, he shouldn't be terribly insulted that you're suggesting an improvement (especially if, as it sounds, it was a quick hack to fix a common problem in as little time as possible).

On the other hand, if you're more interested in keeping out of trouble with your boss (not a criticism; I think we've all had jobs where we're mostly interested in keeping our heads down and out of trouble, and waiting for daylight to get the fsck out of there), you might be better off talking to your supervisor, mentioning that you were playing with the code before he came by, and suggesting that you and the other support guy collaborate on a re-write (helps if you have an idea of what kinds of changes to make before hand, to limit the "don't change that code, it's not worth the time" factor).

--
F o x t r o t U n i f o r m
Found a typo in this node? /msg me
The hell with paco, vote for Erudil!


In reply to Re(2): Should I tell them something is wrong? by FoxtrotUniform
in thread Should I tell them something is wrong? by defyance

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.