My opinion would be to leave it. The best possible result would be you looking like an interfering smart-arse.
I know 'icky' code is something that causes a dedicated perl hacker pain. But at the end of the day, it's someone elses bodge job. If it's 'good enough' then that's fine.
About the only situation where this changes, IMHO is security. (Eg, a 'setuid' program with a unchecked buffer overflow or similar).
In general, the only damaged 'stupid' code does, is to be inefficient. Or perhaps does something unintended when the _owner_ runs it.
In which case, it's their 'baby' to fix.
IMO if someone comes to me and tells me that one of my admin scripts is inefficient, my first thought would be to ask what they are doing messing with admin scripts.
(Not that they are inefficient, it's just an example ;p))
--
It's not pessimism if there is a worse option, it's not paranoia when they are and it's not cynicism when you're right.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.